>Title:
>> Fix for Chat Notifications Merging Logic in src/notifications.js
>>
>Body:
>> Hi NodeBB team,
>> I wanted to share a fix for an issue where chat notifications were not merging correctly, resulting in multiple separate alerts instead of a single grouped notification (e.g., "3 new messages from user").
>> The Issue:
>> The core logic responsible for finding related notifications was sometimes failing to identify previous chat alerts, preventing them from being merged into a single summary notification.
>> The Solution:
>> We modified the merging logic in src/notifications.js to ensure that chat notifications are correctly identified and merged based on their unique identifiers.
>> Here is the corrected code block for the Notifications.push logic:
>> javascript >> if (notification.mergeId) { >> const related = await Notifications.findRelated([notification.mergeId], `uid:${uid}:notifications:unread`); >> const merged = await Notifications.getMultiple(related).then(Notifications.merge); >> if (merged.length) { >> notification = merged.pop(); >> notification.pushed = false; // Ensure it re-triggers the push for the update >> } >> } >> >>
>> Why this works:
>> By forcing notification.pushed = false after merging, we ensure that the updated notification (containing the new count and content) is sent out again, correctly reflecting the merged state to the user.
>> I hope this helps anyone experiencing similar issues with notification grouping!
>> Best regards.

The question is whether this is a professional and proper solution, or if it would be better to find a different one?

However if it works with Android then that suggests that it may be an apple specific issue with how they handle notification rescind. Maybe they require additional data the plugin doesn't send.

Hopefully they support notification rescind.

Indeed, the last commit was written with the aim of solving this problem, but it should be noted that after testing it did not help.

I also do not have Safari to test, and I asked my friend to check with him (such a bad browser... it's a miracle I don't have one <img class="not-responsive emoji" src="https://community.nodebb.org/assets/plugins/nodebb-plugin-emoji/emoji/android/1f605.png?v=82067483ff1" title="" /> )

I did not even remember opening a PR with these commits.

I will now delete the last commit so that the effective code of the previous commits can be merged

My friend @AMAARETS is the one who did what I asked him to do.
But it still didn't help the problem.

Yes, the problem is only with private messages, where several messages are sent in a row.

@baris web push is a direct reflection of regular notifications so if they share merge id, the old push notif is removed and replaced

So I ask you to try to sort this out.
thanks.

So can you fix this please?

I tested it, and indeed it helped.. so you can make this change..
Only there is a very annoying bug

If my friend sends me three private messages in a row, whose content is "Message 1" "Message 2" "Message 3" I would receive three notifications with the following content: "Message 1" "Message 1" "Message 1"
Which means I would receive the same content of the first message in the three notifications...

Did you understand the problem and can you fix it?

It seems to me that this happens because when sending several messages in a row, the message ID is not the same, and then it takes the content from the first message.